Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase memory access page alignment checking to 8KB instead of 4KB #100

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Increase memory access page alignment checking to 8KB instead of 4KB #100

merged 1 commit into from
Apr 29, 2024

Conversation

athornton
Copy link
Contributor

@athornton athornton commented Apr 28, 2024 •
edited by RaymiiOrg
Loading

gdwnldsKSC/es40@dad191f

This just transplants an es40 commit that forces 8K page alignment.

This not only resolves the installation issues, but seems to fix the network-driver-dying problem. In (admittedly somewhat limited) testing, I'm still seeing occasional storms of things like

CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst: ff-ff-ff-ff-ff-ff .. src: 54-af-97-01-ca-f4
CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst: ff-ff-ff-ff-ff-ff .. src: 54-af-97-01-ca-f4
CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst: ff-ff-ff-ff-ff-ff .. src: 54-af-97-01-ca-f4
CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst: ff-ff-ff-ff-ff-ff .. src: 54-af-97-01-ca-f4
CPacketQueue(rx_queue):add() packet lost! Size = 60.. dst: 01-00-5e-00-00-01 .. src: fc-34-97-46-58-30

But where that used to be the point at which the network adapter died and you'd have to restart axpbox to get it working again, now it appears to be recovering. That can happen but if I telnet or FTP to the emulated system it's still responsive, which was not the case before the alignment patch.

At any rate...I think this means that, with this patch, you can use axpbox with a TCP/IP network pretty much indefinitely.

@RaymiiOrg RaymiiOrg changed the title transplant https://github.com/gdwnldsKSC/es40/commit/dad191fb2f279164… Increase memory access page alignment checking to 8KB instead of 4KB Apr 28, 2024
@RaymiiOrg
Copy link
Collaborator

RaymiiOrg commented Apr 28, 2024 •
edited
Loading

Thanks! I've updated your comment and title, to link to the original commit (gdwnldsKSC/es40@dad191f) and to highlight the actual change. Also approved a github actions workflow run, but the rest of the merging is up to @lenticularis39

@lenticularis39
Copy link
Owner

We probably shouldn't always printf that, since it might slow down emulation if there is too much unaligned access, but that can be solved later.

@lenticularis39 lenticularis39 merged commit d26f87b into lenticularis39:main Apr 29, 2024
5 checks passed
This was referenced Apr 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@athornton @RaymiiOrg @lenticularis39